-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new /api/nbresuse/v1 endpoint #52
Comments
For now the code in the API handler: Duplicates some of the logic of the Prometheus handler, which relies on a It would be nice if both could share the same approach when it comes to retrieving metrics from |
It would be interesting to have a look at the glances API: https://github.com/nicolargo/glances/wiki/The-Glances-RESTFULL-JSON-API Glances relies on There might be some ideas that could be applied to nbresuse if we start expanding the API surface. |
#68 provides /api/metrics/v1, without removing /metrics. We can probably tweak it more in a /api/metrics/v2 |
We can add the per kernel metrics #41 since this has been a long ask for lots of people. I myself am using this in my org but was overriding |
#45 restored the
/metrics
endpoint, so that JupyterLab (and other frontends) can display the metrics:The reason to move away from
/metrics
is to not shadow the default Prometheus endpoint (see #22 for more infos).However this is a breaking change. We should carefully plan the rollout to avoid confusing users with an older version of JupyterLab. For the classic notebook this is not really an issue as the notebook extension is bundled with the package on PyPI.
cc @Gsbreddy who has already started working on this in side PRs.
The text was updated successfully, but these errors were encountered: