Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the original error message from GitHub on Admin Check #579

Closed
blink1073 opened this issue Jun 27, 2024 · 3 comments
Closed

Show the original error message from GitHub on Admin Check #579

blink1073 opened this issue Jun 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@blink1073
Copy link
Contributor

Description

The message for when the admin check fails makes some assumptions about the API response, but we should include the full API response to help debugging.

@blink1073 blink1073 added the bug Something isn't working label Jun 27, 2024
@blink1073
Copy link
Contributor Author

@ianthomas23, from what I can tell we are logging the full response,

collab_level = gh.repos.get_collaborator_permission_level(user)
.

Can you post a link to your workflow run here?

@ianthomas23
Copy link

@blink1073 https://github.com/ipython/ipykernel/actions/runs/9699310606/job/26767956167 is the latest run in which the Admin check failed.

@blink1073
Copy link
Contributor Author

Oh, right, that was before we backported the workflow changes. I realized what went wrong after that, we needed to set the branch field in the dialog. I opened #581 to properly handle the case where you run the workflow against a different branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants