New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Image.width/height be of type Int? #2236

Open

maartenbreddels opened this issue Oct 5, 2018 · 1 comment

Member

maartenbreddels commented Oct 5, 2018

Going over #2182 with @SylvainCorlay we were surprised to see that Image.width and height are of type Unicode, while (looking at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img || https://www.w3.org/wiki/Html/Elements/img) the image width and height are in pixels (like what the help string says), so I guess we should convert them to Int?

Member Author

maartenbreddels commented Oct 31, 2018

If we attack this, also rephrase some text: https://github.com/jupyter-widgets/ipywidgets/pull/2182/files#r222999430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment