Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename .lmWidget to .luminoWidget #3137

Closed
jasongrout opened this issue Feb 18, 2021 · 1 comment · Fixed by #3141
Closed

Rename .lmWidget to .luminoWidget #3137

jasongrout opened this issue Feb 18, 2021 · 1 comment · Fixed by #3141
Labels
good first issue
Milestone
8.0

Comments

@jasongrout
Copy link
Member

Problem

In #3118, we discussed whether .lmWidget should be .lumWidget or .luminoWidget in order to be more readable (the lowercase L is often being confused with uppercase I). In our dev meeting today, we had generally positive sentiment to rename it to .luminoWidget.

Proposed Solution

Rename .lmWidget to .luminoWidget
@jasongrout jasongrout added this to the 8.0 milestone Feb 18, 2021
@jasongrout jasongrout mentioned this issue Feb 18, 2021
Merged
@jasongrout
Copy link
Member Author

Setting as good first issue, since this should just be a search and replace of lmWidget for luminoWidget

@davidbrochart davidbrochart mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Rename lmWidget to luminoWidget davidbrochart/ipywidgets
1 participant
@jasongrout