-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipywidgets's HTMLManager package overrides the JupyterLab CSS in nbconvert #3340
Labels
Comments
martinRenou
changed the title
ipywidgets's control package overrides the JupyterLab CSS in nbconvert
ipywidgets's HTMLManager package overrides the JupyterLab CSS in nbconvert
Jan 10, 2022
Edited the title and issue summary. It seems that it's the HTMLManager that's bringing this CSS. For the nbconvert case (HTML Manager):
For the classic Notebook case (widgetsnbextension)
|
I wonder if we could have a conditional require that checks if the labvariables are already available in the page, if they are not, we require them. |
Related issue: jupyter/nbconvert#1506 |
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
ipywidgets's HTMLManager package seems to override JupyterLab CSS variables when loaded
Reproduce
nbconvert==6.4.0
andipywidgets==7.6.5
test.ipynb
containing widgetsjupyter nbconvert --to html --HTMLExporter.theme=dark test.ipynb
theme.mp4
Expected behavior
The resulting HTML page should have a dark theme, ipywidgets should keep the CSS variables untouched when a theme is already loaded.
Ideally, ipywidgets wouldn't even ship those CSS variables.
Extra Context
It seems that, by chance, Voila is not impacted by this issue. I understand that the ipywidgets's control package CSS gets loaded before Voila loads the theme. But I might be wrong.Voila is not impacted by this because it doesn't use HTMLManager.
The text was updated successfully, but these errors were encountered: