-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from Phosphor CSS class names to Lumino names #3357
Milestone
Comments
We also have some
I agree that this is confusing and should be switched over to either lm-based classes or perhaps our own prefix for our own classes that we are adding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the "controls" JS package's CSS we still have references to PhosphorJS CSS class names:
ipywidgets/packages/controls/css/widgets-base.css
Lines 1289 to 1291 in 1b1a49d
Mostly this seems to be
.p-Tabbar
related or.p-mod
. By the time that JupyterLab chooses to drop the deprecated phosphor classes, we will need to update our CSS to either support both names, or to only support the Lumino class names.The text was updated successfully, but these errors were encountered: