Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from Phosphor CSS class names to Lumino names #3357

Closed
vidartf opened this issue Jan 25, 2022 · 1 comment · Fixed by #3366
Closed

Transition from Phosphor CSS class names to Lumino names #3357

vidartf opened this issue Jan 25, 2022 · 1 comment · Fixed by #3366
Milestone

Comments

@vidartf
Copy link
Member

vidartf commented Jan 25, 2022

In the "controls" JS package's CSS we still have references to PhosphorJS CSS class names:

.jupyter-widgets.jupyter-widget-tab > .p-TabBar .p-TabBar-tabIcon,
.jupyter-widgets.jupyter-widget-tab > .p-TabBar .p-TabBar-tabLabel,
.jupyter-widgets.jupyter-widget-tab > .p-TabBar .p-TabBar-tabCloseIcon {

Mostly this seems to be .p-Tabbar related or .p-mod. By the time that JupyterLab chooses to drop the deprecated phosphor classes, we will need to update our CSS to either support both names, or to only support the Lumino class names.

@jasongrout
Copy link
Member

jasongrout commented Jan 25, 2022

We also have some p-* css classes we add.

this.addClass('p-TabPanel');

this.tabBar.addClass('p-TabPanel-tabBar');

this.tabContents.addClass('p-TabPanel-tabContents');

I agree that this is confusing and should be switched over to either lm-based classes or perhaps our own prefix for our own classes that we are adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants