Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note in migration guide the privatization of .widgets and .widget_types #3562

Closed
jasongrout opened this issue Aug 22, 2022 · 2 comments · Fixed by #3567
Closed

Note in migration guide the privatization of .widgets and .widget_types #3562

jasongrout opened this issue Aug 22, 2022 · 2 comments · Fixed by #3567
Labels
Milestone

Comments

@jasongrout
Copy link
Member

Problem

The migration guide does not cover the privatization of .widgets and .widget_types, as noted here.

Suggested Improvement

Put a note in the user migration guide that covers these usecases and provides a shim for accessing the variables in ipywidgets 7 and 8 if needed (though note that the variable is now private in ipywidgets 8, so references are discouraged).

@jasongrout jasongrout added this to the 8.0 milestone Aug 22, 2022
@maartenbreddels
Copy link
Member

See also how I fix this in react-ipywidgets:
widgetti/reacton@6fb0784

@jasongrout
Copy link
Member Author

jasongrout commented Aug 23, 2022

In the dev meeting today, @maartenbreddels volunteered to put in a PR that deprecates (but doesn't remove) the Widget class .widgets and .widget_types attributes (i.e., reverses their removal, and makes it a deprecation). We prefer to have this as a module-level constant (for example, possibly named WIDGETS and WIDGET_TYPES), rather than as a class attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants