Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle execute_request_impl(allow_stdin = ) #41

Open
romainfrancois opened this issue Nov 14, 2023 · 1 comment
Open

Handle execute_request_impl(allow_stdin = ) #41

romainfrancois opened this issue Nov 14, 2023 · 1 comment

Comments

@romainfrancois
Copy link
Contributor

No description provided.

@adamblake
Copy link

@SylvainCorlay is this what would allow inputs via functions like readline()? I have seen this sort of thing used in fairly popular packages (and also in not as popular packages like coursekata) to get user input before:

  • doing something that might be destructive
  • installing a missing dependency
  • performing something computationally intensive

It's not critical for any of our specific use-cases at CourseKata, but I think it is generally going to be expected by other users. If it's hard to accomplish, maybe it would be helpful to have a "phase 1" of the feature where it expresses an error explaining that user inputs don't work. Currently if a package asks for user input it just enters an endless loop of spamming for user input in the kernel logs while appearing busy in the notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants