Add support for async kernel management #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
force-pushed
the
async-subclasses
branch
from
71fc22e
to
10df48f
Compare
kevin-bates
force-pushed
the
async-subclasses
branch
from
4e43a9e
to
8b89f5d
Compare
kevin-bates
changed the title
|
Updated the Notebook dependency to 6.1.0rc1. The plan moving forward is that we'll create an EG 2.2.0rc1 release. Once Notebook 6.1.0 is released, the dependency will be updated and we can then cut EG 2.2.0. |
|
@lresende and @akchinSTC - a gentle reminder that your review is pending. Thank you in advance. |
lresende
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of PR #580 due to branch changes - the description is essentially the same, however.
Updated RemoteKernelManager's methods to async/await and derive from jupyter_client's
AsyncIOLoopKernelManagerandRemoteMappingKernelManagernow derives from notebook'sAsyncMappingKernelManager. As a result, this PR will NOT be back-ported to 1.x.NOTE: Installation of this PR requires that BOTH related Jupyter Client 428 and Notebook 4479 PRs be merged. Once merged, we need to update our dependencies to depend on those versions - thus the
[DEPENDENCY]in the title.Fixes #86
Fixes #592
The PRs referenced above have been updated to reflect the recent PRs submitted that use a subclass-based approach. Please see those PRs for a description the class hierarchy.