Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow input on comm messages #285

Open
jasongrout opened this issue Aug 8, 2017 · 2 comments
Open

Allow input on comm messages #285

jasongrout opened this issue Aug 8, 2017 · 2 comments

Comments

@jasongrout
Copy link
Member

jasongrout commented Aug 8, 2017

The execute request message has an allow_stdin parameter to instruct the kernel if input could be handled. However, the comm messages do not have a similar parameter, which means, for example, you can't set a breakpoint in a comm message handler and have interactive debugging.

If we had such a parameter in comm messages, they would no longer be symmetric, but this is still an important usecase.

See jupyter-widgets/ipywidgets#1603, CC @TimShawver.

For an implementation, it looks like essentially, we'd need to do something like https://github.com/ipython/ipykernel/blob/8acaee80c83c9a64a22afde522f9df2d0c3638e4/ipykernel/ipkernel.py#L200 and https://github.com/ipython/ipykernel/blob/8acaee80c83c9a64a22afde522f9df2d0c3638e4/ipykernel/ipkernel.py#L206 when processing comm messages, i.e.:

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants