Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags and Aliases on Extensions are failing #140

Closed
echarles opened this issue Nov 16, 2019 · 2 comments
Closed

Flags and Aliases on Extensions are failing #140

echarles opened this issue Nov 16, 2019 · 2 comments

Comments

@echarles
Copy link
Member

Defining flags (or aliases) on Sever Extension have shown not to be working at different places:

This is opened to [1] Confirm the issue [2] Define a fix.

@echarles
Copy link
Member Author

echarles commented Nov 16, 2019

There are 2 aspects here:

  • Does it make sense that the base Extension imports the flags and alias from jupyter_server.serverapp as it does not extend it. Probably yes as we want to extension to influence the global ServerApp
  • Launching with a flag or a alias via the entrypoint works (e.g. jupyter simple-ext11 --hello) however launching via jupyter server --ServerApp.jpserver_extensions="{'simple_ext11': True}" --hello fails with Unrecognized flag: '--hello'

@echarles
Copy link
Member Author

Discussing this at the server weekly meeting, @Zsailer confirmed it was the expected behavior (you need to start with the entrypoint to have the flags operational). Closing this issue.

Zsailer added a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
* consolidate launch methods

* Bump to 0.12.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant