add basic login.html template #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
reviewed
May 5, 2020
There was a problem hiding this comment.
Thanks, @Mistobaan! This is great!
A couple of things...
- Do you mind migrating the
logout.htmltemplate here too? - Let's drop the
classattributes from all HTML tags, since we're not going to style any of these templates from Jupyter Server. Those tags are specific to the Jupyter Notebook frontend.
|
@Zsailer done also added missing message output that I just noticed on the logout page. |
Zsailer
approved these changes
May 5, 2020
|
Fantastic! Thanks, @Mistobaan. |
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
add basic login.html template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to run a jupyter-server with just basic password it will fail with
500on the login handler with the error "login.html" not found.This PR fixes the error. The code is extracted from jupyter-notebook login.html