Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call tornado StaticFileHandler.get() as a coroutine #315

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Call tornado StaticFileHandler.get() as a coroutine #315

merged 2 commits into from
Mar 15, 2019

Conversation

lresende
Copy link
Member

No description provided.

@lresende lresende changed the title Call tornado WebSocketHandler.get() as a coroutine [WIP]Call tornado WebSocketHandler.get() as a coroutine Mar 15, 2019
@lresende lresende changed the title [WIP]Call tornado WebSocketHandler.get() as a coroutine Call tornado WebSocketHandler.get() as a coroutine Mar 15, 2019
@lresende
Copy link
Member Author

These changes support Tornado version 6.0 and above, and help fix the Enterprise Gateway build issues while using Tornado 6.0.1

@lresende lresende requested a review from kevin-bates March 15, 2019 05:51
kevin-bates
kevin-bates reviewed Mar 15, 2019
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. You should probably update the title to be StaticFileHandler since it's not a WebSocketHandler, but I see that web.StaticFileHandler is using the native async def coroutine - so subclasses need to be handled similarly - good catch.

@lresende lresende changed the title Call tornado WebSocketHandler.get() as a coroutine Call tornado StaticFileHandler.get() as a coroutine Mar 15, 2019
kevin-bates
kevin-bates approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lresende!

@lresende lresende merged commit b27aec8 into jupyter-server:master Mar 15, 2019
@lresende lresende deleted the tornado_6 branch March 15, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lresende @kevin-bates