-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project dependencies may have API risk issues #255
Comments
I will second this, I encountered a breaking event loop bug from |
The decision was made to not add upper bounds to dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, In nbclient, inappropriate dependency versioning constraints can cause risks.
Below are the dependencies and version constraints that the project is using
The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict.
The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.
After further analysis, in this project,
The version constraint of dependency jupyter_client can be changed to >=7.0.6,<=7.3.4.
The above modification suggestions can reduce the dependency conflicts as much as possible,
and introduce the latest version as much as possible without calling Error in the projects.
The invocation of the current project includes all the following methods.
The calling methods from the jupyter_client
The calling methods from the all methods
@developer
Could please help me check this issue?
May I pull a request to fix it?
Thank you very much.
The text was updated successfully, but these errors were encountered: