-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #31
Comments
There's one issue that came up internally here in testing papermill 2.0 and nbclient around nested papermill calls from subprocesses that might be related to nbclient holding onto kernel state too long. I'm going to test for that more this weekend and submit a fix if it is the root cause (haven't made an issue for it yet). Other than that I think we can do a release unless there's anything you know about that we need to address first.
Whoops, fixed now. |
I am also not super sure whether or not I've uncovered a bug in #7 - if that's a bug, it should probably be a blocker on a release as well |
I can dig into that one as well, I think it's likely a config issue but yes we should figure that out first |
I got a little sick this weekend, will dig in and help get a release out after I'm feeling better. |
@MSeal don't sweat it, and I hope you feel better! |
Release is out finally! Thanks everyone for the hard work |
Thanks a lot Matthew! |
hooray!!! 🎉🎉🎉 congrats everybody, and thanks @MSeal for pushing us over the finish line :-) |
Do we want to tag on GitHub too? I only see 0.1.0 in https://github.com/jupyter/nbclient/releases |
Done. I thought I had pushed the tags too but I guess I missed that. |
We all owe you a 🍺 @MSeal |
When do you plan to make a release? We need one in order to have async execution in Voila (voila-dashboards/voila#541).
Also, I saw that nbclient was released in PyPI (https://pypi.org/project/nbclient/#history) but not in the GitHub repo.
The text was updated successfully, but these errors were encountered: