Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #31

Closed
davidbrochart opened this issue Feb 28, 2020 · 11 comments
Closed

Release #31

davidbrochart opened this issue Feb 28, 2020 · 11 comments
Labels
question Further information is requested
Milestone

Comments

@davidbrochart
Copy link
Member

davidbrochart commented Feb 28, 2020

When do you plan to make a release? We need one in order to have async execution in Voila (voila-dashboards/voila#541).
Also, I saw that nbclient was released in PyPI (https://pypi.org/project/nbclient/#history) but not in the GitHub repo.

@MSeal
Copy link
Contributor

MSeal commented Feb 28, 2020

There's one issue that came up internally here in testing papermill 2.0 and nbclient around nested papermill calls from subprocesses that might be related to nbclient holding onto kernel state too long. I'm going to test for that more this weekend and submit a fix if it is the root cause (haven't made an issue for it yet). Other than that I think we can do a release unless there's anything you know about that we need to address first.

Also, I saw that nbclient was released in PyPI (https://pypi.org/project/nbclient/#history) but not in the GitHub repo.

Whoops, fixed now.

@MSeal MSeal added the question Further information is requested label Feb 28, 2020
@choldgraf
Copy link
Contributor

I am also not super sure whether or not I've uncovered a bug in #7 - if that's a bug, it should probably be a blocker on a release as well

@MSeal
Copy link
Contributor

MSeal commented Feb 28, 2020

I can dig into that one as well, I think it's likely a config issue but yes we should figure that out first

@MSeal
Copy link
Contributor

MSeal commented Mar 2, 2020

I got a little sick this weekend, will dig in and help get a release out after I'm feeling better.

@choldgraf
Copy link
Contributor

@MSeal don't sweat it, and I hope you feel better!

@MSeal MSeal added this to the 0.2.0 milestone Mar 8, 2020
@MSeal MSeal mentioned this issue Mar 9, 2020
@MSeal
Copy link
Contributor

MSeal commented Mar 31, 2020

Release is out finally! Thanks everyone for the hard work

@MSeal MSeal closed this as completed Mar 31, 2020
@davidbrochart
Copy link
Member Author

Thanks a lot Matthew!

@choldgraf
Copy link
Contributor

hooray!!! 🎉🎉🎉

congrats everybody, and thanks @MSeal for pushing us over the finish line :-)

@davidbrochart
Copy link
Member Author

Do we want to tag on GitHub too? I only see 0.1.0 in https://github.com/jupyter/nbclient/releases

@MSeal
Copy link
Contributor

MSeal commented Apr 1, 2020

Done. I thought I had pushed the tags too but I guess I missed that.

@choldgraf
Copy link
Contributor

We all owe you a 🍺 @MSeal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants