Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master test failure #73

Closed
SylvainCorlay opened this issue May 27, 2020 · 10 comments
Closed

Master test failure #73

SylvainCorlay opened this issue May 27, 2020 · 10 comments

Comments

@SylvainCorlay
Copy link
Member

Thee tests on master appear to be failing on Windows + Python 3.6 over OSError: [WinError 6] The handle is invalid.

I re-started the tests to see if this occurs all the time, because the PR that was merged last was passing.

@SylvainCorlay
Copy link
Member Author

Edit: always failing on windows-latest 3.6.

@davidbrochart
Copy link
Member

It looks a lot like the issue we had in jupyter_server, basically there was a bug in Python on Windows that has been fixed and back-ported to python >= 3.7 (https://bugs.python.org/issue37380).

@MSeal
Copy link
Contributor

MSeal commented May 27, 2020

Thanks for raising. If someone hasn't dug into fixing this in a couple days I should have time at the end of the week to fix builds. There's a number of doc build failures across projects as well that need tweaks to repair :/

@willingc
Copy link
Member

nbclient doc builds are passing.

@SylvainCorlay
Copy link
Member Author

has been fixed and back-ported to python >= 3.7 (https://bugs.python.org/issue37380).

Thanks! Do you know if there is an advertized workaround so that we don't have to drop support for windows and Python 3.6.

@davidbrochart
Copy link
Member

I couldn't find any.

@SylvainCorlay
Copy link
Member Author

We should ask for one on the CPython issue.

@MSeal
Copy link
Contributor

MSeal commented May 29, 2020

Agreed. @davidbrochart do you have enough context to make that issue? I'm less familiar with the nature of the issue.

@davidbrochart
Copy link
Member

See #77

@MSeal
Copy link
Contributor

MSeal commented May 30, 2020

Looks like it's all resolved now. Thanks @davidbrochart !

@MSeal MSeal closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants