Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBConvert 5.6 Release #1052

Closed
MSeal opened this issue Jun 17, 2019 · 13 comments
Closed

NBConvert 5.6 Release #1052

MSeal opened this issue Jun 17, 2019 · 13 comments
Assignees
Milestone

Comments

@MSeal
Copy link
Contributor

MSeal commented Jun 17, 2019

We have a lot of really nice features merged into nbconvert that don't need to wait for the 6.0 release. We're waiting for jupyter_client to release jupyter/jupyter_client#438 (should be any day now) to enable parallel processing. There's still a rare race condition for ipython kernels, but ipython/ipykernel#412 once passing should resolve the issues there. I don't want to block the release on this change.

Are there any open PRs we want merged before such a release? I will note I do not have time to finish the requested changes on #986 for this release. I will endeavour to fix that before 6.0 if I can though.

@t-makaro
Copy link
Contributor

t-makaro commented Jun 17, 2019

#1028 I'll make a change to it later today, and I'll push a version of #947 so that at least we can get better errors from latex.

@MSeal
Copy link
Contributor Author

MSeal commented Jun 17, 2019

You can steal the code I added to #986 for nbconvert/exporters/pdf.py to handle errors better. That part was solid.

@MSeal
Copy link
Contributor Author

MSeal commented Jul 29, 2019

@t-makaro @willingc Do we want to get the minimal version of #947 in for this release of just bump it to a later release? Are there any other open issues / bugs that we should tackle first? I do want to get 5.6 out soon.

@MSeal
Copy link
Contributor Author

MSeal commented Jul 29, 2019

Also an FYI ipython/ipykernel#412 got merged but there's some issue with the fixes for the tests, so master is in a broken state. We'll need to note the status or need to upgrade ipykernel to allow for parallel ipython kernel executions.

@willingc
Copy link
Member

Do we want to get the minimal version of #947 in for this release of just bump it to a later release? Are there any other open issues / bugs that we should tackle first? I do want to get 5.6 out soon.

I would bump these to 5.7 (or 6.0).

@willingc willingc added this to the 5.6 milestone Jul 29, 2019
@willingc
Copy link
Member

willingc commented Jul 29, 2019

Needed for release:

@t-makaro
Copy link
Contributor

I'll take another crack at #947 tomorrow. Otherwise, skip until a later release.

@MSeal
Copy link
Contributor Author

MSeal commented Aug 6, 2019

Making the Changelog FYI, let's pause merging until the release is completed in the next day or two.

@MSeal
Copy link
Contributor Author

MSeal commented Aug 6, 2019

No response on the ipykernel front... I'll try to dig into it Wednesday night to see if I can determine what's wrong there on my own.

@willingc
Copy link
Member

willingc commented Aug 7, 2019

@minrk If you have any free time, do you have any thoughts on ipython/ipykernel#412? Specifically, ipython/ipykernel#412 (comment). Thanks 😄

@minrk
Copy link
Member

minrk commented Aug 7, 2019

I think ipython/ipykernel#419 fixes the shutdown issue

@MSeal
Copy link
Contributor Author

MSeal commented Aug 7, 2019

Appears to make nbconvert run smoothly again with the current changes in ipykernel master. Thanks! I'll make an issue on ipykernel to organize a patch release there.

@MSeal
Copy link
Contributor Author

MSeal commented Aug 7, 2019

Ok I'll work on getting a PR up tonight for the changelog -- I think we're on track to get a full release this week finally done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants