Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpining depency on nbconvert 5.6.1? #1411

Closed
nthiery opened this issue Feb 9, 2021 · 6 comments
Closed

Unpining depency on nbconvert 5.6.1? #1411

nthiery opened this issue Feb 9, 2021 · 6 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Feb 9, 2021

nbgrader --version

0.7 dev

Issue

nbgrader is pinning an old version of nbconvert (5.6.1).

"nbconvert==5.6.1",

Is this a strong dependency? Could it be lifted to allow for nbgrader 6 which
was released in August 2020?

We have a rather fat image for our JupyterHub, and this is putting stress
on the constraints resolution. Also preventing the use of, e.g. voila which
uses nbgrader 6.

Thanks in advance!

@nthiery nthiery changed the title Unpining depency on nbconvert 5.6.1 Unpining depency on nbconvert 5.6.1? Feb 9, 2021
@rkdarst
Copy link
Contributor

rkdarst commented Feb 9, 2021

there is some discussion in #1369. #1405 is my attempt to fix it, there are still some template things to fix. That PR should set someone on the path towards removing it (once they solve the problem there, and any other problems that come up).

I wouldn't count on me having time until mid-year.

@nthiery
Copy link
Contributor Author

nthiery commented Feb 9, 2021

Ok; thanks for the update!

@rkdarst
Copy link
Contributor

rkdarst commented Feb 13, 2021 via email

@nthiery
Copy link
Contributor Author

nthiery commented Feb 19, 2021

Yes, that's how I understood it:-) If I see opportunities to inject a bit of man power there, I'll try!

@jhamrick
Copy link
Member

Thanks for reporting, I think I've just about figured it out in #1421!

Closing as duplicate of #1367

@nthiery
Copy link
Contributor Author

nthiery commented Mar 19, 2021

Great! Thank you so much @jhamrick . Looking forward to the resolution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants