Skip to content

Commit 765c9f7

Browse files
committed
Implement Thomas Kluyver's idea -- let the contents and kernel managers get the application option as part of calculating the default
1 parent 9640e1f commit 765c9f7

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

notebook/notebookapp.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1270,14 +1270,6 @@ def _notebook_dir_validate(self, proposal):
12701270
raise TraitError(trans.gettext("No such notebook dir: '%r'") % value)
12711271
return value
12721272

1273-
@observe('notebook_dir')
1274-
def _update_notebook_dir(self, change):
1275-
"""Do a bit of validation of the notebook dir."""
1276-
# setting App.notebook_dir implies setting notebook and kernel dirs as well
1277-
new = change['new']
1278-
self.config.FileContentsManager.root_dir = new
1279-
self.config.MappingKernelManager.root_dir = new
1280-
12811273
# TODO: Remove me in notebook 5.0
12821274
server_extensions = List(Unicode(), config=True,
12831275
help=(_("DEPRECATED use the nbserver_extensions dict instead"))

0 commit comments

Comments
 (0)