Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-indent is only available when editing cells #2591

Closed
edgimar opened this issue Jun 21, 2017 · 3 comments · Fixed by #3175
Closed

Auto-indent is only available when editing cells #2591

edgimar opened this issue Jun 21, 2017 · 3 comments · Fixed by #3175

Comments

@edgimar
Copy link

edgimar commented Jun 21, 2017

The auto-indent feature introduced in PR #963 only applies when editing cells in a notebook. It would be nice if this could also apply to the file-editor interface (e.g. when viewing / editing an entire python file).

@gnestor
Copy link
Contributor

gnestor commented Jan 2, 2018

The indentAuto shortcut was removed because it was causing issues for French/German/etc keyboards (see #2535). It would be nice to add it back with a different keymap.

@Carreau Apparently, keymaps like Ctrl-Alt-[ and Cmd-Alt-[ disable French and German keyboards from typing [. What about Cmd-Shift-[? Would that be ok? What aboutCmd-\?

@gnestor
Copy link
Contributor

gnestor commented Jan 2, 2018

Cmd-Shift-[ is the shortcut for switching tabs in Chrome...

@Carreau
Copy link
Member

Carreau commented Jan 3, 2018

The typical reasonig for shortcut is the following:

No shortcut should use Alt (or Shift but in a lesser measure) by default. None. Ever.

Many non-english keyboard need Alt and or Shift to type characters. So Shift and Alt are not available.

Typically, french keyboard use Shift for Numbers. So Cmd-Shift-[ is actually "Cmd-5" on a french keyboard... which is taken, and on French keyboard typing [ actually require pressing Alt-Shift-5... so I'm not even sure how that will conflict resolve, or if this could trigger ghost shortcuts.

Hence I would prefer not to do it. What we can (and maybe should) do, is provide a set of "nice but not enabled by default" keymap that are a click away, and provide a "Querty-layout" extra, "Azerty layout extra", "Cyrillic extra", where we can go as crazy as we like.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants