include nbjs.json / .mo in source ?

[Carreau]

As far as I can tell, with current release process there is no translation included.

We can also make sure they are build into wheels ?
Otherwise there is no frontend translation in released wheel which can be weirdly hard to setup.

[Carreau]

@takluyver you excluded them initially.

[minrk]

Aren't only the LC_MESSAGES required for frontend translation? They are included in package_data and I get UI translations when I run

LANG=fr_FR jupyter notebook

after installing from a wheel

[Carreau]

I did try and it did not work for me locally, If I read correctly there is also some translations in the json files and some translations in the .po files to to get everything translated you need both, and you need both LANG and the browser set to the same value

See https://github.com/jupyter/notebook/blob/master/notebook/i18n/README.md#known-issues-and-future-evolutions

[minrk]

I was able to confirm that with what's already packaged, frontend translations do work from a wheel (no files outside locale/xx_YY are used for translations at runtime).

This is the result from:

python setup.py bdist_wheel
pip install dist/*.whl
cd
LANG=fr_FR jupyter notebook

With language settings (chrome):

The result, where you can see frontend translations are using zh_CN and backend translations are using fr_FR:

So I think with #3931, which fixes the exclusions from sdists, we can release 5.7. Do you agree?

[Carreau]

Do you agree?

Yes. Sound good to me.

[minrk]

Great! Notebook 5.7 is out