Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.1.0 #5423

Closed
24 tasks done
kevin-bates opened this issue May 5, 2020 · 11 comments
Closed
24 tasks done

Release 6.1.0 #5423

kevin-bates opened this issue May 5, 2020 · 11 comments

Comments

@kevin-bates
Copy link
Member

kevin-bates commented May 5, 2020

There have been some pull requests merged (and others waiting) that probably warrant more than a patch release, so I'd like to start the process of putting things together for a Notebook 6.1.0 release. Preferably, this would be based on master.

Here are the commits since 6.0.3, most of which came with #4479 - which is a primary reason for introducing a minor release.

Other PRs I think we should include - although I don't necessarily expect all these to make the release...

If there are other issues and/or pull requests you'd like to see in a 6.1.0 release, please add comments and I'll amend this text - or feel free to amend this yourself (if privs allow).

@willingc
Copy link
Member

@blink1073 @kevin-bates Would it be possible to release a 6.0.4 with minimally the fix for #4835 which prevents installing in a Python 3 virtual environment? Installing requests-unixsocket would not resolve the install failure. Pulling master and building from HEAD worked.

Alternatively, 6.1 would be great too. 😄

@kevin-bates
Copy link
Member Author

Hi @willingc - thanks for the heads up.

I'm a little confused in trying to understand your comment from an urgency perspective. Neither #4835 nor the fix I believe you're referring to (#5451) have been released - both in master waiting for their "carrier". So was your py3 installation issue the result of cherry-picking #4853 (having not also taken #5451)?

Our intention is to build 6.1 from master but if there's more at play here I suppose we could look into an interim patch release. Although, having never built a notebook release, I should defer to Steve on that.

I was going to suggest at least one rc release (for 6.1) so we can discover, and workout, any kinks as well.

@kevin-bates
Copy link
Member Author

Release 6.1.0rc1 has been pushed to PyPI. Does conda-forge handle pre-releases? If so, I'd prefer to wait to announce the RC.

I was going to post in the google groups, gitter, and discourse forums. Are there other locations?

@blink1073
Copy link
Contributor

Thanks!

Pre-releases on conda are possible: I added an rc branch to the feedstock.
Here is an example rc PR from JupyterLab: conda-forge/jupyterlab-feedstock#206
And the JuptyerLab branch: https://github.com/conda-forge/jupyterlab-feedstock/tree/rc

I think those ANN locations sound good.

@kevin-bates
Copy link
Member Author

Thanks Steve! I've submitted conda-forge/notebook-feedstock#68 targeting the rc branch and based on the jupyterlab example.

@kevin-bates
Copy link
Member Author

@Zsailer, @blink1073, @afshin - could you please review the set of unmarked tasks above? I think we need to try to get 6.1 out soon (preferably next week) and I believe the unmarked items are ready (with the exception of #5259).

Also, Steve, I noticed you marked some of these with a 6.2 milestone and I suspect that was to prevent 'feature creep'. Just wondering your thoughts on including them in 6.1?

I'd like to go ahead and include the Russian I18N work since that's the kind of thing that shouldn't be too disruptive if there are issues that were not caught in review. Any objections?

@blink1073
Copy link
Contributor

I just didn't want to step on your toes. I merged the ones that were waiting in the wings.

@Zsailer
Copy link
Member

Zsailer commented Jul 23, 2020

Thank you for championing this forward, @kevin-bates! I merged #5593.

I would think we should bump #5259 to 6.2, since there hasn't been activity on that PR in awhile.

I'd like to go ahead and include the Russian I18N work since that's the kind of thing that shouldn't be too disruptive if there are issues that were not caught in review. Any objections?

👍 I agree!

@afshin
Copy link
Member

afshin commented Jul 23, 2020

I agree with Zach. If they do not come back to update it, I can take a more serious look at that PR if we think it's important and we can put it in 6.2.

@kevin-bates
Copy link
Member Author

Thank you for your timely responses and all your help! I'll finalize the changelog and let things sit for a day or so, then release 6.1.0 GA.

@kevin-bates
Copy link
Member Author

6.1.0 is released - thank you all for your help with this!

@kevin-bates kevin-bates unpinned this issue Jul 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants