Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon not explicitly specified for /tree (Notebook v7) #6607

Closed
mcrutch opened this issue Oct 31, 2022 · 0 comments · Fixed by #6608
Closed

favicon not explicitly specified for /tree (Notebook v7) #6607

mcrutch opened this issue Oct 31, 2022 · 0 comments · Fixed by #6608

Comments

@mcrutch
Copy link
Contributor

mcrutch commented Oct 31, 2022

If Jupyter Server is configured at a base_url other than / and a different service is handling the / url, the favicon for Jupyter will not appear on the /tree in Notebook v7 because it looks for /favicon.ico
Scenario:

  • c.ServerApp.base_url = '/Jupyter/'
  • Notebook v7/Labv4/NBClassic
  • nginx server running on 80/443 that forwards /Jupyter/ to jupyter server running in the background
  • favicon.ico served by NGINX that is not Jupyter's favicon
  • visit http:///Jupyter/tree

Outcome:

  • Favicon on tab is what is served by NGINX, not what is served by Jupyter

Solution:

  • Block similar to this on the /tree view that inserts the favicon explicitly via metadata just like JupyterLab does and Notebook v7 does for some sub-pages: 804cd3a
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 31, 2022
@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Nov 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants