Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text editor should display a partial view with a drop shadow #6785

Closed
JasonWeill opened this issue Mar 22, 2023 · 3 comments
Closed

Text editor should display a partial view with a drop shadow #6785

JasonWeill opened this issue Mar 22, 2023 · 3 comments
Labels
Milestone

Comments

@JasonWeill
Copy link
Collaborator

The bottom of the page of the text editor shows the white document portion going all the way to the bottom. It should render like a "document" - in other words, a white piece of paper on a grey table.

This was found during a bug bash by @ellisonbg .

See also #6781.

Screen Shot 2023-03-20 at 3 31 30 PM

@JasonWeill JasonWeill added the bug label Mar 22, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 22, 2023
@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

For reference the editor in the Classic Notebook goes almost all the way to the bottom (it has a small margin bottom):

image

@jesuscastillx
Copy link
Contributor

Currently waiting on guidance for the shadow aspect of this issue, but I got another PR that fixes the white space :)

@jtpio jtpio modified the milestones: 7.0, 7.0.x May 15, 2023
@jtpio
Copy link
Member

jtpio commented Jun 15, 2023

Closing as fixed by #6804

@jtpio jtpio closed this as completed Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants