Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blind users with screenreader read everything in German #6924

Closed
Tracked by #6800
tonyfast opened this issue Jun 16, 2023 · 5 comments
Closed
Tracked by #6800

Blind users with screenreader read everything in German #6924

tonyfast opened this issue Jun 16, 2023 · 5 comments
Labels
tag:Accessibility
Milestone
7.0.x

Comments

@tonyfast
Copy link
Collaborator

tonyfast commented Jun 16, 2023 •
edited
Loading

Language

  • Expectation: Language tags are specified on <html> element based on the language the content is being displayed as. If content is in English, needs to be <html lang="en">, etc. (WCAG Criteria 3.1.1 (A) and 3.1.2 (AA))
  • Observed:
    • On all pages with my language set to English, lang="default" which reads my content in GERMAN (probably looking at the first 2 letters "de"). Need to have JS that powers this instead change to the proper lang codes.
    • If importing over the Settings Editor to Notebookv7 ever, recommend adding dropdown menu for languages so user only selects from list of languages that are currently supported/installed so bilingual blind users can easily toggle without fear of messing up.
@tonyfast tonyfast mentioned this issue Jun 16, 2023
Open
16 tasks
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Jun 16, 2023
@tonyfast tonyfast changed the title Blind users with screenreader read everything in German no matter what (JS sets lang as an invalid type: "default") Blind users with screenreader read everything in German Jun 16, 2023
@tonyfast
Copy link
Collaborator Author

i spent some time looking for where the lang attribute is set on the application. i am sure this has some overlapping complications with the translation module.

this one should be easy to solve for somewho knows where the lang attribute is set.

@andrii-i andrii-i removed the status:Needs Triage Applied to issues that need triage label Jun 16, 2023
@andrii-i andrii-i added this to the 7.0.x milestone Jun 16, 2023
@andrii-i
Copy link
Contributor

Thank you for creating this issue @tonyfast

This was referenced Jun 17, 2023
Closed
Merged
@andrii-i
Copy link
Contributor

Problem seems to be in the lab (jupyterlab/jupyterlab#14704), opened PR to fix it there jupyterlab/jupyterlab#14705

@andrii-i
Copy link
Contributor

jupyterlab/jupyterlab#14705 was merged. Next steps would be releasing/waiting for JypyterLab version with 14705 included and updating Notebook to it.

@tonyfast
Copy link
Collaborator Author

tonyfast commented Jun 24, 2023 •
edited
Loading

thanks for getting this done. closing it and checking it off the milestone.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag:Accessibility
Projects
None yet
Milestone
7.0.x
Development

No branches or pull requests
2 participants
@tonyfast @andrii-i