Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe symbol in connecting DockerHub registry docs can be confusing #811

Closed
sgibson91 opened this issue Mar 20, 2019 · 1 comment · Fixed by #813
Closed

Pipe symbol in connecting DockerHub registry docs can be confusing #811

sgibson91 opened this issue Mar 20, 2019 · 1 comment · Fixed by #813

Comments

@sgibson91
Copy link
Member

sgibson91 commented Mar 20, 2019

Link to Discourse topic

I've just built a BinderHub that pushes images to a DockerHub organization and became slightly confused by the pipe (|) symbol in the documentation: <docker-id|organization-name>/<prefix>-.

I read this as literal and put both my ID and my organization into the config file which caused my BinderHub to fail to build as repo2docker was throwing an "invalid image name" error. After reading the note box more thoroughly, I realised my mistake and everything now works but perhaps we can make this more transparent in the documentation for skim-readers?

E.g. maybe explicitly saying "or": <docker-id OR organization-name>/<prefix>-?

Happy to open a PR when we've decided on a suitable phrasing. Thank you! ✨

@betatim
Copy link
Member

betatim commented Mar 21, 2019

Using an English word instead of | sounds like a good solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants