Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slashes on full URLs for repos that do not use ref #953

Open
nuest opened this issue Sep 16, 2019 · 1 comment
Open

Trailing slashes on full URLs for repos that do not use ref #953

nuest opened this issue Sep 16, 2019 · 1 comment

Comments

@nuest
Copy link
Contributor

nuest commented Sep 16, 2019

Zenodo and Figshare (and possibly other repos) do not use the ref, leading to a trailing slash in the generated URL, e.g.

http://localhost:8585/v2/zenodo/10.5281/zenodo.3242074/

Do we want to remove that? Could be done in function v2url(..) in binderhub/static/js/index.js.

I'm in the "remove" corner, thinking of a URL ending / as a directory. Here's some wisdom by others:

(Or should we use the ref to identify the version or a record? Don't think r2d transparently supports this right now.)

@betatim
Copy link
Member

betatim commented Sep 17, 2019

I don't have a strong opinion on this. Without a trailing slash looks nicer, but I have to admit I hardly ever look/pay attention to this.

We should make sure that were possible we are forgiving to users and accept with and without trailing slash where possible. The number of hours I've spent staring at two seemingly equal URLs (where one worked and the other didn't) to help a user who had added/removed a / is far too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants