-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version format doesn't work with helm 3 #86
Comments
Whaaaaat nooooooo! Arrrgh the second helm issue with version parsing... Sigh this should be valid! |
This is the Helm code base that cause the error: This is a regression of masterminds/semver version 3+ as can be seen in this Go playground: https://play.golang.org/p/XcOuf-z_y6v |
Complicated... Apparently it isnt OK according to SemVer to have a identifier, which is the sections between the dots, that is numeric and leads with a zero. This create an issue both for our commit-number since release and for the git hash. The git hash can be fully numeric with a leading zero if we are unlucky. I have been unlucky with regards to it being totally numerical before... My suggestion, is that we change the specification once again to resolve this, to make it on of the below:
I lean towards the first or third option. What do you think @manics and @betatim ? |
Testing with the latest binderhub helm chart dev releases:
This works:
This fails:
This also fails:
The text was updated successfully, but these errors were encountered: