Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support admin_users query #72

Closed
JoeJasinski opened this issue May 30, 2018 · 4 comments
Closed

Feature Request: support admin_users query #72

JoeJasinski opened this issue May 30, 2018 · 4 comments

Comments

@JoeJasinski
Copy link

Hi all,

It would be great if this authenticator could support an LDAP query that would designate admin_users and update that list dynamically (not require a restart). Since ldapauthenticator already has all of the machinery to access LDAP, it seems like it might be a good place to optionally populate the admin_users set based on an LDAP query. Thanks for reading.

@dhirschfeld
Copy link
Collaborator

That sounds sensible though whether or not it requires a restart is probably up to JupyterHub

@timhughes
Copy link

Also having c.LDAPAuthenticator.admin_groups which accepts a list similar in implementation to c.LDAPAuthenticator.allowed_groups

@mk-raven
Copy link

mk-raven commented Jul 2, 2024

Any updates of this issue?
5 years have passed..

@consideRatio
Copy link
Member

Closing this in favor of #260. I'm reducing this to listing users to not change the typical behavior of Authenticator.admin_users though, but admin_groups or similar could be implemented to get admin users if they are part of an admin group. This is tracked by #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants