Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure in main branch #261

Closed
consideRatio opened this issue Jan 4, 2024 · 2 comments · Fixed by #274
Closed

Test failure in main branch #261

consideRatio opened this issue Jan 4, 2024 · 2 comments · Fixed by #274

Comments

@consideRatio
Copy link
Member

Not yet investigated
@consideRatio consideRatio mentioned this issue Jan 4, 2024
Open
@manics
Copy link
Member

manics commented Aug 7, 2024

pytest (3.8, jupyterhub==1.* sqlalchemy==1.*) is currently failing https://github.com/jupyterhub/nativeauthenticator/actions/runs/10257308097/job/28378109882. All other matrix jobs including pytest (3.9, jupyterhub==2.* sqlalchemy==1.*) are passing.

Given that JupyterHub 1 is ancient and probably has several CVEs that are fixed in later versions I think we should drop it rather than trying to fix the failing test. Arguably we could drop JupyterHub 2, and maybe 3 too, to reduce the future maintenance burden

@manics manics mentioned this issue Aug 7, 2024
Merged
@consideRatio
Copy link
Member Author

👍 dropping support for jh <4

@consideRatio consideRatio mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require jupyterhub 4.1.6+ and Python 3.9+ consideRatio/nativeauthenticator
2 participants
@manics @consideRatio