Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgitpuller binder link generator not working with repos other than GitHub.com #286

Open
fkohrt opened this issue Dec 15, 2022 · 2 comments
Labels

Comments

@fkohrt
Copy link

fkohrt commented Dec 15, 2022

Bug description

The nbgitpuller link generator makes it look like you can enter any "Git Environment Repository URL", while in fact no working links are generated for GitLab.com repositories.

Expected behaviour

Either a correct label such as GitHub Environment Repository URL or actually working links.

Actual behaviour

If I enter e.g. https://gitlab.com/fkohrt/RMarkdown-sandbox and some content repository (e.g. https://github.com/binder-examples/r), the resulting link starts with https://mybinder.org/v2/gh/ instead of https://mybinder.org/v2/gl/ and does not turn fkohrt/RMarkdown-sandbox into fkohrt%2FRMarkdown-sandbox

@fkohrt fkohrt added the bug label Dec 15, 2022
@yuvipanda yuvipanda changed the title nbgitpuller link generator not working with GitLab.com nbgitpuller binder link generator not working with GitLab.com Dec 16, 2022
@yuvipanda
Copy link
Contributor

Thanks for opening this! This only applies to the binder tab, right?

@fkohrt
Copy link
Author

fkohrt commented Dec 16, 2022

I never used the other tabs so I don't know if they have a similar issue, I noticed it when using the Binder tab.

Also I just noticed that this is not limited to GitLab.com, but in fact applies to all providers other than GitHub.com. Here's a small collection of repos that work with mybinder.org but not with the nbgitpuller link generator:

GitLab (Framagit)

  • Repo: https://framagit.org/prof_sabra/seconde-snt.git
  • Git ref: 0db14ba2da1198cbca74d37ce97fc60d9de9ba7c

Gitea (Codeberg)

  • Repo: https://codeberg.org/LadueCS/Intro-to-Python.git
  • Git ref: ea6c32c16e8713e7f8f35e6e6c4ec0b913526f4f

Sourcehut

  • Repo: https://git.sr.ht/~hww3/pike-binder-example
  • Git ref: df3fa933205c13a8a0efc6e04293de848d7adf91

Note that actually launching Sourcehut repos currently does not seem to work, see jupyterhub/binderhub#1590.

Bitbucket

  • Repo: https://bitbucket.org/ueacomputervision/image-labelling-tool.git
  • Git ref: 101af660416f35070e59da3a44a5e57f2b7e2397

@fkohrt fkohrt changed the title nbgitpuller binder link generator not working with GitLab.com nbgitpuller binder link generator not working with repos other than GitHub.com Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants