Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github IDs with Capital Letters #52

Closed
jkuruzovich opened this issue Oct 4, 2016 · 3 comments
Closed

Github IDs with Capital Letters #52

jkuruzovich opened this issue Oct 4, 2016 · 3 comments

Comments

@jkuruzovich
Copy link

I’m using login with Github option and having some issues with a few students logging into Jupyterhub. I’ve just tested and I think it is because of capital letters. Unix doesn’t like the capital letters but i’ve tried it both ways (giving all lower case or forcing all upper case) and doesn't seem to allow either way.

Is this option able to handle logging in with GitHub ID's that contain capital letters?

@minrk
Copy link
Member

minrk commented Oct 4, 2016

What version of JupyterHub and oauthenticator? The existing normalization should take care of this.

@jkuruzovich
Copy link
Author

I'm using the https://github.com/jupyterhub/jupyterhub-deploy-teaching.
- jupyterhub==0.6
- oauthenticator==0.3

I set to manually create the users:
adduser -q --home /home/ilovedatascience8 --gecos "" ilovedatascience8 --disabled-password
Then I manually added them to the whitelist in the jupypter config file.

The original userID is: ILoveDataSCIENCE8
(I also tried using the capital version and it didn't work either.

I'm unable to find anything else in the logs but it results in a 443 error.

@minrk
Copy link
Member

minrk commented Feb 16, 2017

Current version (Hub 0.7 and oauth 0.5.1) should work with mixed-case github users. I think there were one or two places where normalization wasn't applied in 0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants