Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cleanup of resources for deleted users via the new delete_forever hook in the Spawner base class #88

Open
consideRatio opened this issue Oct 26, 2021 · 1 comment

Comments

@consideRatio
Copy link
Member

Any Spawner working against JupyterHub 1.4.1 and later can now optionally implement use of a delete_forever function.

If implemented, the spawner can do cleanup work associated with a JupyterHub admin pressing the Delete button on a specific user. This has been implemented in KubeSpawner for example, see jupyterhub/kubespawner#475. The logic to support such function was added in jupyterhub/jupyterhub#3337.

Perhaps systemdspawner could provide such function, that also is influenced by additional systemdspawner specific options to decide if a user should be deleted, the home directory should be deleted, and perhaps also something else I've missed? I figure we can make this function default to not doing cleanup if we want to avoid a breaking change, which would make this entirely opt-in.

Would this be possible?

@yuvipanda
Copy link
Collaborator

That sounds like a useful addition.

@consideRatio consideRatio removed their assignment May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants