Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAuthenticator: Change password / Authorize links missing in top navigation bar at /hub/home UI #571

Open
Bluejay47 opened this issue May 12, 2020 · 7 comments
Labels
bug Something isn't working priority Issue selected to have a bit higher priority

Comments

@Bluejay47
Copy link

Proposed change

End points such as /hub/authorize and /hub/change-password don't seem to appear in the UI (I use the Lab UI - possibly "change password" appears in the notebook UI?). It would be very helpful if at least /hub/authorize appeared in the admin section when the Native Authentication module is enabled.

Who would use this feature?

Everyone, but particularly new users and admins.

@consideRatio consideRatio added the bug Something isn't working label Oct 25, 2021
@consideRatio consideRatio changed the title Authentication End Points Not Apparent in UI NativeAuthenticator: Change password / Authorize links missing in top navigation bar at /hub/home UI Oct 25, 2021
@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2021

To clarify, the Change password and Authorize links described in this issue are to be be shown like in the image below are not showing up.

image

I'm not sure why, perhaps this is a permissions issue for templates installed by nativeauthenticator? I suspect this isn't an issue of https://github.com/jupyterhub/nativeauthenticator itself, but an issue of TLJH integration with nativeauthenticator.

@lambdaTotoro do you know if I can debug this failure by searching for some template installed by nativeauthentictor in some specific folder or similar?

@lambdaTotoro
Copy link

My first intuition would be that this has something to do with the changes introduced in jupyterhub/nativeauthenticator#79 . Since they were introduced, things need a little bit of extra fiddling with the template path. That's written about in the installation section of our docs, but I don't know if that made it over to tljh.

@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2021

@lambdaTotoro ah! No I think that is merged after this has been observed in version 0.0.7 I think, but would things just work if installing 1.0.5 at this point perhaps?

If using 1.0.5, do we also need to configure something like this?

import os
import nativeauthenticator

c.JupyterHub.template_paths = [f"{os.path.dirname(nativeauthenticator.__file__)}/templates/"]

I answered this myself by reading the docs, yes we have to do that: https://native-authenticator.readthedocs.io/en/latest/quickstart.html#installation

@lambdaTotoro
Copy link

I think that'd be worth a shot. Is there a way you could try that and see if it works?

@consideRatio
Copy link
Member

@lambdaTotoro I think so yepp!

@consideRatio consideRatio added the priority Issue selected to have a bit higher priority label Oct 26, 2021
@benjamir
Copy link

From my POV this is still an issue with 1.0 (we started with the release before).

@seam-ctooley
Copy link

Can confirm this is still an issue on a fresh installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Issue selected to have a bit higher priority
Projects
None yet
Development

No branches or pull requests

5 participants