Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the "how to prepare your Dockerfile" section #484

Closed
2 tasks done
choldgraf opened this issue Feb 6, 2018 · 4 comments
Closed
2 tasks done

Improve the "how to prepare your Dockerfile" section #484

choldgraf opened this issue Feb 6, 2018 · 4 comments

Comments

@choldgraf
Copy link
Member

choldgraf commented Feb 6, 2018

Hit three main use-cases:

  • Option 1: Use jupyter-dockerstacks as a pre-existing image
  • Option 2: Creating your own Dockerfile from scratch
  • Option 3: Use repo2docker

Current in 0.7.0:

  • Selection of jupyter/docker-stacks
  • Extension of jupyter/docker-stacks
@consideRatio
Copy link
Member

I restructured this section for jupytercon2018, many started using repo2docker and failing since for different reasons and unmet expectations on the outcome.

The current docs have:

  1. Choosing an image from docker-stacks
  2. Extending such image

I'm open for the update of:
3. Short note about building one from scratch and known but perhaps not exhaustive requirements on the Dockerfile. (jupyterhub package, the startup command, uid, more?)


This means that we currently no longer provide a repo2docker suggested path to get a suitable z2jh image. I found that it was a lot more complicated and led to complications with storage etc as compared to the docker-stack options. This led to the opinion that repo2docker shouldn't be suggested as an option within z2jh to build user images.

@manics
Copy link
Member

manics commented Jun 10, 2020

Is this still on the todo list?

@consideRatio
Copy link
Member

Yepp I think so =/

@consideRatio
Copy link
Member

I'm closing this as we have "Choose and use an existing Docker image" and "Customize an existing Docker image", I feel this is sufficient for now without explicit user requests for more. See: https://zero-to-jupyterhub.readthedocs.io/en/latest/customizing/user-environment.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants