Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch builds for this repo #500

Closed
yuvipanda opened this issue Feb 13, 2018 · 7 comments
Closed

Fix branch builds for this repo #500

yuvipanda opened this issue Feb 13, 2018 · 7 comments

Comments

@yuvipanda
Copy link
Collaborator

Currently, if you push to a branch in this repo, Travis fails.

We should fix this!

@willingc
Copy link
Collaborator

@yuvipanda Do you think the latest addition of chartpress and the changes to .travis.yml fix this?

@consideRatio
Copy link
Member

We currently end up with two builds on travis running, this is not the correct behavior i figure.

@consideRatio
Copy link
Member

This is an example of an troublesome behavior, where we get two builds, one because we get a PR, and one because we added a branch.

Actionplan:

  1. Ensure we only do one build in this case. For an example of this issue see the build for CHANGELOG.md contained duplicate instructions #877

@betatim
Copy link
Member

betatim commented Sep 12, 2018

Why not recommend against having private branches in this repository? We operate via PRs for all change so people have their own fork already and can do what they like there.

My preference for this is part "keeping the master repository tidy" and "only special people can make branches here and I don't like having special people".

@yuvipanda
Copy link
Collaborator Author

@betatim absolutely agree :)

@betatim
Copy link
Member

betatim commented Sep 14, 2018

-> close this issue? Or is there a GitHub setting we can/should use to enforce this?

@willingc
Copy link
Collaborator

I don't think that GitHub offers a straightforward way to prevent new branch creation. I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants