Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minikube instructions in CONTRIBUTING.md #552

Closed
willingc opened this issue Mar 2, 2018 · 2 comments
Closed

Update minikube instructions in CONTRIBUTING.md #552

willingc opened this issue Mar 2, 2018 · 2 comments

Comments

@willingc
Copy link
Collaborator

willingc commented Mar 2, 2018 •
edited
Loading

Step 7 for the local minikube CONTRIBUTING.md installation instructions errors when running on MacOS High Sierra.

I believe that the error is due to RBAC and/or permissions. Perhaps after the switch to chartpress this changed.
@manics
Copy link
Member

manics commented Mar 2, 2018

CI uses minikube with RBAC enabled: https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/ci/install.sh#L27

If you're updating the instructions to enable RBAC might be worth pointing out this bug: kubernetes/minikube#2510
Fix (for v0.25.0) was kubectl create clusterrolebinding kube-system-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default

@willingc willingc closed this as completed Mar 2, 2018
@willingc
Copy link
Collaborator Author

willingc commented Mar 2, 2018

Closed by #554. Thanks @manics for the additional info 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manics @willingc