Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a message when a Docker image is being pulled onto a node #690

Closed
choldgraf opened this issue May 19, 2018 · 4 comments
Closed

Emit a message when a Docker image is being pulled onto a node #690

choldgraf opened this issue May 19, 2018 · 4 comments

Comments

@choldgraf
Copy link
Member

Sometimes it's good to know if a Docker image pull is happening. A good example is in BinderHub, where users don't understand why a session launch is taking much longer than normal (and it's usually because the pull operation takes a while to complete).

One way we could solve this is to have JupyterHub emit a message when a user session is launched for an image that doesn't currently exist on the node. BinderHub could then grab this message and display something to the user so they know it'll take longer than expected. I imagine administrators of JupyterHub also might find this useful as we start supporting cases where people launch a wider variety of Docker images from a JupyterHub deployment.

@consideRatio
Copy link
Member

Yes!

Should we attempt to make something z2jh specific / kubespawner specific or perhaps make something spawner generic perhaps?

Hmmm, is it possible for the kubespawner to report if the pod is pending or pulling also? That would be nice?

@choldgraf
Copy link
Member Author

yeah I was wondering the same thing as I posted this...not sure if Z2JH is the best place for this, so if somebody has opinions about where it should go, feel free to suggest another repo!

@yuvipanda
Copy link
Collaborator

jupyterhub/kubespawner#153 and related from @clkao is what is needed here :)

@consideRatio
Copy link
Member

consideRatio commented Jul 21, 2018

Closed! :D Thanks @clkao and @minrk I love this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants