When deleting a file, also delete the favorite

[mlucool]

If you delete a file via lab, it does not also get removed from favorites. It means you need to go to favorites and remove it from there as well. Can we change this behavior to keep this in sync?

I am not sure if this plugin should handle a favorite being deleted outside of lab (e.g. via git pull, or rm -f etc.), but it seems worthwhile to consider.

[mlhenderson]

There was a "purge" action that happened when you tried to select a favorite and it was no longer available which removed the favorite. However, this was problematic for network file systems where the favorite may be temporarily unavailable but not deleted, and so that "purge" behavior was dropped.

This does imply manual syncing of deleted favorites currently.

I'm interpreting "inside" lab delete somewhat narrowly as selecting the file/directory in the file browser and selecting delete (or move? or rename?) from the UI. @mlucool is this the context you are assuming?

[mlucool]

However, this was problematic for network file systems where the favorite may be temporarily unavailable but not deleted, and so that "purge" behavior was dropped.

That makes sense.

I'm interpreting "inside" lab delete somewhat narrowly as selecting the file/directory in the file browser and selecting delete (or move? or rename?) from the UI

Yes that is what I meant. It would be nice is move/rename kept the favorite and did the a similar action too.

[fcollonval]

Thanks for the suggestion @mlucool

We could indeed use the following signal (snippet taken from jupyterlab-git extension):

  // Whenever a user adds/renames/saves/deletes/modifies a file within the lab environment, refresh the Git status
  app.serviceManager.contents.fileChanged.connect(() =>
    gitExtension.refreshStatus()
  );