Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim mode disabled for first cell when code cell extension is installed or for current cell when changing CodeMirror settings #123

Closed
firai opened this issue Oct 9, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@firai
Copy link
Collaborator

firai commented Oct 9, 2023

Description

When a code cell extension, such as jupyterlab-execute-time, is installed alongside jupyterlab-vim, vim mode does not initialize in the first cell, and the user must switch to another cell and back in order to enable vim in the first cell.

Upon triage by @krassowski, changing CodeMirror settings for code cells also causes vim mode to be disabled for the current cell.

Reproduce

Type 1

  1. Install both jupyterlab-vim and jupyterlab-execute-time
  2. Create a new notebook

Type 2

  1. Install jupyterlab-vim alone
  2. Change CodeMirror settings

Expected behavior

vim mode properly initializes regardless of other extensions

Context

  • Extension versions:
    jupyterlab-vim 4.0.3
    jupyterlab-execute-time 3.0.1
  • Operating System and its version: Windows
  • Browser and its version: Latest Firefox and Edge
@firai firai added the bug Something isn't working label Oct 9, 2023
@krassowski
Copy link
Collaborator

Would you mind opening an issue over in jupyterlab-execute-time?

@firai
Copy link
Collaborator Author

firai commented Oct 10, 2023

Investigated by @krassowski at deshaw/jupyterlab-execute-time#97 (comment). To be tracked here.

@firai firai changed the title vim mode not enabled for first cell when jupyterlab-execute-time is installed vim mode disabled for first cell when code cell extension is installed or for current cell when changing CodeMirror settings Oct 10, 2023
@firai firai added the help wanted Extra attention is needed label Oct 15, 2023
@firai
Copy link
Collaborator Author

firai commented Oct 17, 2023

Seems like this doesn't occur with every CodeMirror extension. When I use jupyterlab-vim with jupyterlab-indent-guides, neither first load nor changing settings for jupyterlab-indent-guides from the Settings Editor disables vim mode.

@firai
Copy link
Collaborator Author

firai commented Sep 8, 2024

It seems like the conflict with jupyterlab-execute-time has been fixed by deshaw/jupyterlab-execute-time#120.

@firai firai removed the help wanted Extra attention is needed label Sep 8, 2024
@firai firai closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants