-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl-O
prefixed commands not working in jupyterlab>=4.1.0
#138
Comments
I can confirm this bug. @krassowski is there any chance this is related to the shortcut changes again? from https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#change-of-notebook-focus-handling-impacting-command-mode-shortcut-selectors
we aren't using that tag, but maybe the auto conversion of things somehow got us? here's the definition of an example broken shortcut: jupyterlab-vim/schema/plugin.json Lines 73 to 77 in b0a90a9
|
I do not think so. It seems like the events are not properly intercepted so it might be the fallout from the change of the keydown capture mode in jupyterlab 4.1. |
Any update on this? |
@krassowski Is there anything we can do at the extension level? Or do we need to wait until jupyterlab/jupyterlab#15897 is resolved? |
Description
Vim command shortcuts that start with
Ctrl-O
(i.e., Cut Cell, Copy Cell, Paste Cell, Insert Cell Below, Insert Cell Above, Select First Cell, Select Last Cell, Center Cell) are not working since jupyterlab 4.1.0.At the moment, I am requiring versions
jupyterlab==4.0.9
andjupyterlab-vim==4.1.0
to keep these bindings working.Reproduce
Fresh install:
pip install 'jupyterlab>=4.1.0,<5.0.0a0' jupyterlab-vim
In new notebook, any selected cell, edit mode, press
Ctrl-O, O
orCtrl-O, Ctrl-O
, orCtrl-O, G
, etc… the expected jupyter shortcut doesn't happen (i.e., insert cell below/above, select first cell).However, the editor does respond with the vim command mapped to the keys after the
Ctrl-O
s. For example,Ctrl-O, O
inserts a new line and switches to insert mode, as if the^O
prefix was never pressed.Context
Let me know if can provide any additional information.
The text was updated successfully, but these errors were encountered: