Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.0 broken - cannot use 'c' key #63

Closed
shinypond opened this issue Mar 12, 2022 · 12 comments · Fixed by #64
Closed

0.15.0 broken - cannot use 'c' key #63

shinypond opened this issue Mar 12, 2022 · 12 comments · Fixed by #64
Labels
bug Something isn't working

Comments

@shinypond
Copy link

After the latest update, the key 'c' is unavailable when the insert mode of vim.

Is this a bug?

Description

Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error '...'

Expected behavior

Context

  • Python package version:
  • Extension version:
  • Operating System and its version:
  • Browser and its version:
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Web Browser Output
Paste the output from your browser web console here.
@shinypond shinypond added the bug Something isn't working label Mar 12, 2022
@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

Hi @shinypond thanks for reporting!

Is this a bug?

If this is happening consistently in 0.15.0 and not in 0.14.5 then it is almost certainly a bug :(.

Can you please confirm that if you downgrade jlab vim to 0.14.5 in the same environment then c works again?

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

oh boy. It sure it broken. That's really not great. I wish we had tests that could check things like this.

@shinypond
Copy link
Author

Thanks for your reply!!

I have just installed jlab vim through the jupyter lab extension tab(leftside in the web), without any terminal command such as pip.
Then how can I downgrade jlab vim to 0.14.5? Use pip install?

Anyway, I hope this problem be solved soon...

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

I have just installed jlab vim through the jupyter lab extension tab(leftside in the web)

hmm. I don't know much about how to use that. I would in the terminal do the following:

jupyter labextension uninstall @axlair/jupyterlab_vim
pip install jupyterlab-vim==0.14.5

Anyway, I hope this problem be solved soon...

me too 😞 . Looking around I havne't been able to figure out the cause. If other people could put some eyes on it that'd be really helpful! Full diff here: 0.14.5...0.15.0

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

Oh wow - you can't even type the letter c I though you just couldn't do things like ciw. That's really bad. Worth considering pulling that release off pypi if it's not an obvious fix. I'm going to bed but can try to think more about this tomorrow

@ianhi ianhi pinned this issue Mar 12, 2022
@ianhi ianhi changed the title Key 'c' is unavailable. 0.15.0 broken - cannot use 'c' key Mar 12, 2022
@shinypond
Copy link
Author

Okay. Thanks for your efforts. Have a good night!

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

I spoke too soon :) I may have i figured it out

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

now I don't think i can sleep until I at least try this

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

ok. Thanks again for reporting!

new version should be published as soon as https://github.com/jupyterlab-contrib/jupyterlab-vim/runs/5520553204?check_suite_focus=true finished (and then conda-forge version a few hours later)

@ianhi
Copy link
Collaborator

ianhi commented Mar 12, 2022

@shinypond if you get a chance could you try out the new version and confirm that it works for you? Now it truly is bedtime for me i think

@shinypond
Copy link
Author

Everything is now okay!!! Thanks a lot @ianhi !!

@wiseyoungbuck
Copy link

Thanks a bunch. Quite excited to have this back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants