Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we detach the fork? #78

Closed
krassowski opened this issue Mar 12, 2023 · 2 comments
Closed

Should we detach the fork? #78

krassowski opened this issue Mar 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@krassowski
Copy link
Collaborator

I just lost quite some time trying to push to #69 to fix up the lint errors before merging. It seems that while the PR author agreed maintainers to modify it:

Screenshot from 2023-03-12 22-38-02

It looks that github rejects my edits when pushed from local repo. This is strange as I can push via GitHub UI. I believe it is related to this repository being a fork and the PR fork being associated with jwkvam/jupyterlab-vim rather than jupyterlab-contrib/jupyterlab-vim.
@krassowski krassowski added the enhancement New feature or request label Mar 12, 2023
@firai
Copy link
Collaborator

firai commented Mar 25, 2023 •
edited
Loading

Deforking was discussed in #66, but it hasn't happened yet for whatever reason

@krassowski
Copy link
Collaborator Author

Closing as duplicate of #66.

@krassowski krassowski closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@firai @krassowski