Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruff formatter #330

Closed
devmcp opened this issue Nov 9, 2023 · 3 comments
Closed

Support ruff formatter #330

devmcp opened this issue Nov 9, 2023 · 3 comments

Comments

@devmcp
Copy link

devmcp commented Nov 9, 2023

As of ruff v0.1.2 it supports formatting as well as linting. It would be great to support this natively.

There is a walkthrough here with a workaround, but I couldn't get it to work (I get "Formatter ruff_format not found" despite adding it to the jupyterlab config and restarting jupyterlab).

@samsja
Copy link

samsja commented Jan 22, 2024

any news on this issue ? Big fan of this project and ruff is great

@axeltlarsson
Copy link

I'd love for this project to natively support ruff too.

Meanwhile I'm trying out the workaround linked above, but having some issues with the fact that formatting through jyputerlab_code_formatter doesn't format the same way as if running ruff format from the command line... Mildly infuriating to say the least, and makes it really difficult to use in CI. Any ideas why? It should use the same binary and version, it's just one goes through jyputerlab_code_formatter and the other doesn't as far as I can tell.

@krassowski
Copy link
Contributor

Closing as fixed by #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants