Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is failing on master branch #142

Open
krassowski opened this issue Apr 2, 2023 · 1 comment
Open

CI is failing on master branch #142

krassowski opened this issue Apr 2, 2023 · 1 comment
Labels
bug Something isn't working status:Needs Triage

Comments

@krassowski
Copy link
Member

  • Execute benchmark tests for validation strop is failing since end of February: https://github.com/jupyterlab/benchmarks/actions/runs/4280818726/jobs/7453054661

    Run set -ex
  set -ex
  # Update the snapshots
  BENCHMARK_NUMBER_SAMPLES=1 PW_VIDEO=1 jlpm run test --project testing -u
  # Check that all tests pass with updated snapshots
  BENCHMARK_NUMBER_SAMPLES=1 PW_VIDEO=1 jlpm run test --project testing
  shell: /usr/bin/bash -e {0}
  env:
    BENCHMARK_SWITCHES: 3
    pythonLocation: /opt/hostedtoolcache/Python/3.10.10/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.10/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.10/x64/lib
+ BENCHMARK_NUMBER_SAMPLES=1
+ PW_VIDEO=1
+ jlpm run test --project testing -u
yarn run v1.22.19
$ tsc --incremental -p tsconfig.json
Error: ../node_modules/@types/node/ts4.8/test.d.ts(612,34): error TS1005: '?' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(613,17): error TS1005: ':' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(614,17): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(617,34): error TS1005: '?' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(618,17): error TS1005: ':' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(619,17): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(619,26): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(620,5): error TS1109: Expression expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(624,24): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(628,35): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(634,39): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(638,21): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,19): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,27): error TS1005: ':' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,36): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,55): error TS1005: '{' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,64): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(643,77): error TS1005: ',' expected.
Error: ../node_modules/@types/node/ts4.8/test.d.ts(647,22): error TS1005: ',' expected.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 2.

  • An earlier step, Launch JupyterLab started failing since as seen on master of my fork (fully synced with upstream): https://github.com/krassowski/benchmarks/actions/runs/4589258332/jobs/8104021108

     Run jlpm install
   jlpm install
   # Mount a volume to overwrite the server configuration
   jlpm start-jlab [2](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:2)>&1 > /tmp/jupyterlab_server.log &
   shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
   env:
     BENCHMARK_SWITCHES: [3](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:3)
     pythonLocation: /opt/hostedtoolcache/Python/3.10.10/x6[4](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:4)
     PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.10/x64/lib/pkgconfig
     Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
     Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
     Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.10/x64
     LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.10/x64/lib
   
 ➤ YN0070: Migrating from Yarn 1; automatically enabling the compatibility node-modules linker 👍
 
 ➤ YN0000: ┌ Resolution step
 Resolution step
   ➤ YN0061: │ @evocateur/pacote@npm:9.6.[5](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:5) is deprecated: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
   ➤ YN00[6](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:6)1: │ @evocateur/libnpmaccess@npm:3.1.2 is deprecated: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
   ➤ YN0061: │ @evocateur/npm-registry-fetch@npm:4.0.0 is deprecated: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
   ➤ YN0061: │ read-package-tree@npm:5.3.1 is deprecated: The functionality that this package provided is now in @npmcli/arborist
   ➤ YN0061: │ readdir-scoped-modules@npm:1.1.0 is deprecated: This functionality has been moved to @npmcli/fs
   ➤ YN0061: │ uuid@npm:3.4.0 is deprecated: Please upgrade  to version [7](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:7) or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v[8](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:8).dev/blog/math-random for details.
   ➤ YN0061: │ querystring@npm:0.2.0 is deprecated: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
   ➤ YN0061: │ @evocateur/libnpmpublish@npm:1.2.2 is deprecated: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
   ➤ YN0061: │ @npmcli/move-file@npm:1.1.2 is deprecated: This functionality has been moved to @npmcli/fs
   ➤ YN0061: │ node-fetch-npm@npm:2.0.4 is deprecated: This module is not used anymore, npm uses minipass-fetch for its fetch implementation now
   ➤ YN0061: │ source-map-resolve@npm:0.5.3 is deprecated: See https://github.com/lydell/source-map-resolve#deprecated
   ➤ YN0032: │ fsevents@npm:2.3.2: Implicit dependencies on node-gyp are discouraged
   ➤ YN0061: │ @npmcli/move-file@npm:2.0.1 is deprecated: This functionality has been moved to @npmcli/fs
   ➤ YN0061: │ request@npm:2.88.2 is deprecated: request has been deprecated, see https://github.com/request/request/issues/3142
   ➤ YN0061: │ resolve-url@npm:0.2.1 is deprecated: https://github.com/lydell/resolve-url#deprecated
   ➤ YN0061: │ urix@npm:0.1.0 is deprecated: Please see https://github.com/lydell/urix#deprecated
   ➤ YN0061: │ source-map-url@npm:0.4.1 is deprecated: See https://github.com/lydell/source-map-url#deprecated
   ➤ YN0061: │ har-validator@npm:5.1.5 is deprecated: this library is no longer supported
   ➤ YN0061: │ mkdirp-promise@npm:5.0.1 is deprecated: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
   ➤ YN0061: │ popper.js@npm:1.16.1 is deprecated: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
   ➤ YN0032: │ leveldown@npm:5.6.0: Implicit dependencies on node-gyp are discouraged
   ➤ YN0002: │ @jupyterlab-benchmarks/table-render@workspace:extensions/fixed-data-table doesn't provide react-dom (pa8553), requested by fixed-data-table-2
   ➤ YN0002: │ @jupyterlab/application@npm:3.6.3 doesn't provide crypto (pfde1e), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/apputils@npm:3.6.3 doesn't provide crypto (pf6235), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/builder@npm:3.6.3 doesn't provide crypto (p0a20[9](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:9)), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/cells@npm:3.6.3 doesn't provide crypto (pf05ee), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/codeeditor@npm:3.6.3 doesn't provide crypto (pc9273), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/codemirror@npm:3.6.3 doesn't provide crypto (p7ee66), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/codemirror@npm:3.6.3 doesn't provide yjs (pac1cf), requested by y-codemirror
   ➤ YN0002: │ @jupyterlab/coreutils@npm:5.6.3 doesn't provide crypto (p9bc55), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/docmanager@npm:3.6.3 doesn't provide crypto (p89acc), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/docprovider@npm:3.6.3 doesn't provide crypto (p3c205), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/docprovider@npm:3.6.3 doesn't provide yjs (pc7994), requested by y-websocket
   ➤ YN0002: │ @jupyterlab/docregistry@npm:3.6.3 doesn't provide crypto (p6566d), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/filebrowser@npm:3.6.3 doesn't provide crypto (pe680c), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/galata@npm:4.5.3 doesn't provide crypto (pa9d20), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/nbformat@npm:3.6.3 doesn't provide crypto (pcf328), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/notebook@npm:3.6.3 doesn't provide crypto (pd0582), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/observables@npm:4.6.3 doesn't provide crypto (p6661c), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/outputarea@npm:3.6.3 doesn't provide crypto (p28759), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/rendermime-interfaces@npm:3.6.3 doesn't provide crypto (pb230c), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/rendermime@npm:3.6.3 doesn't provide crypto (p4c525), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/services@npm:6.6.3 doesn't provide crypto (pf1e13), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/settingregistry@npm:3.6.3 doesn't provide crypto (p03049), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/statedb@npm:3.6.3 doesn't provide crypto (p03c0d), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/statusbar@npm:3.6.3 doesn't provide crypto (p7bf82), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/translation@npm:3.6.3 doesn't provide crypto (p429[10](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:10)), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/ui-components@npm:3.6.3 [66f46] doesn't provide crypto (p6976f), requested by @lumino/coreutils
   ➤ YN0002: │ @jupyterlab/ui-components@npm:3.6.3 [7a438] doesn't provide crypto (p20226), requested by @lumino/coreutils
   ➤ YN0002: │ @lumino/application@npm:1.31.4 doesn't provide crypto (p43fa4), requested by @lumino/coreutils
   ➤ YN0002: │ @lumino/commands@npm:1.21.1 doesn't provide crypto (pf607b), requested by @lumino/coreutils
   ➤ YN0002: │ @lumino/dragdrop@npm:1.14.5 doesn't provide crypto (pc4019), requested by @lumino/coreutils
   ➤ YN0002: │ @lumino/polling@npm:1.[11](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:11).4 doesn't provide crypto (p53824), requested by @lumino/coreutils
   ➤ YN0002: │ @lumino/widgets@npm:1.37.2 doesn't provide crypto (p763f2), requested by @lumino/coreutils
   ➤ YN0002: │ @octokit/rest@npm:16.43.2 doesn't provide @octokit/core (p84523), requested by @octokit/plugin-request-log
   ➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
   
 ➤ YN0000: └ Completed in [14](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:14)s 891ms
 ➤ YN0000: ┌ Post-resolution validation
 Post-resolution validation
   ➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
 ➤ YN0000: └ Completed
 ➤ YN0000: Failed with errors in [15](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:16)s [47](https://github.com/krassowski/benchmarks/actions/runs/4589476259/jobs/8104389851?pr=2#step:11:48)ms
 Error: Process completed with exit code 1.
@krassowski krassowski added bug Something isn't working status:Needs Triage labels Apr 2, 2023
@krassowski
Copy link
Member Author

I guess #140 attempts to addresses this?

@krassowski krassowski mentioned this issue May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status:Needs Triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krassowski