-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out react based rendering possibly? #15
Comments
To note, the goal with that commit was to try to move React as a layer in the rendering that wouldn't be visible at all to end users, i.e. keep the public APIs exactly the same, but just swap in React for Lumino for rendering outputs (and possibly other parts of the notebook). What that means, if we moved forward on this approach, is that we would likely have many sandwhiches of react - lumino - react - lumino - etc, if we gaurantee keeping the public APIs still lumino based. |
Sweet. Will look at that and see if we can upgrade that with react-virtualized or react-window |
Note that I never tried this out, so it most likely doesn't work at the moment! |
@saulshanabrook I have taken over your work and pushed more in https://github.com/datalayer-contrib/jupyterlab/tree/react-notebook The basic stream kernel messages are now rendered in the react output area. |
Nice! |
I wanted to leave this commit here, where I started to make a go at refactoring the outputs at least to be wrapped in React components, to allow easier virtualization: saulshanabrook/jupyterlab@f110812
I stopped after a bit, because I wanted to first create the benchmarks, and then once those were done I was busy.
The text was updated successfully, but these errors were encountered: