-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Jupyter should be able to handle large notebooks #75
Comments
@mlucool scrolling is definitely hitting some layout issues in Colab- the switch between virtualized and the real editor incurs some solid layout issues. But typing isn't terrible. https://colab.research.google.com/gist/blois/68f1dc5b50ea315de5071c978d0b3f35/generated-2000cells.ipynb |
Thanks for the example! Cross-referencing jupyterlab/jupyterlab#9757 - large notebooks can choke the UI due to overuse of layout reflows. It looks like the fix will need to land in lumino. |
Problem
We should add a benchmark test and make changes so that 2k cell notebooks feels good to work with. In practice, I have seen some users make notebook in the 1k-ish range, so 2k is an arbitrary number that is bigger than that (maybe it should be 10k?).
We'd first need to define "feels good to work with" a bit more, which I'll state as something like:
All the numbers and metrics above are just somewhere to get started. Happy to put in other metrics and/or change any of the numbers as I choose them somewhat arbitrarily as well. That being said, today none of these metrics pass.
What is is like today?
Given this generated notebook (note, there is no output for any cell which makes this simpler than in the real world):
In lab 3.1 I am finding the following performance when I open the above notebook and try to use it:
Zooming in, all the work seems to be this codemirror pattern over and over again:
While we are working on things like jupyterlab/jupyterlab#10370 and jupyterlab/lumino#231 I thought it would be good to set a both a bit more defined goal and give everyone the same example to test against.
@blois, I'm curious how this notebook performs with the new colab virtualization (#68 (comment)).
What do others think?
CC those who have come to performance meetings as this size notebook was a topic of our first meeting. @fcollonval @sagemaster @echarles @Zsailer @jasongrout @afshin @ellisonbg @3coins @goanpeca
The text was updated successfully, but these errors were encountered: