Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Debuggable interface #338

Open
jtpio opened this issue Jan 14, 2020 · 0 comments
Open

Debuggable interface #338

jtpio opened this issue Jan 14, 2020 · 0 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Jan 14, 2020

The notebook and console handlers share similar code when it comes to handling cells and editors:

private _addEditorHandler(cell: Cell) {
const modelId = cell.model.id;
if (cell.model.type !== 'code' || this._cellMap.has(modelId)) {
return;
}
const codeCell = cell as CodeCell;
const editorHandler = new EditorHandler({
debuggerService: this._debuggerService,
editor: codeCell.editor
});
codeCell.disposed.connect(() => {
this._cellMap.delete(modelId);
editorHandler.dispose();
});
this._cellMap.set(cell.model.id, editorHandler);
}

We could investigate how to make them more generic, for example by implementing a common interface.

@afshin afshin added this to the Future milestone Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants