Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Trove/PyPI classifiers for MIME renderers and themes by default when bootstrapping extensions of the respective type #88

Closed
joaopalmeiro opened this issue Sep 20, 2024 · 1 comment · Fixed by #89
Labels
enhancement New feature or request

Comments

@joaopalmeiro
Copy link
Contributor

Hi! 👋

Problem

When starting a new mimerenderer or theme extension, the respective Trove/PyPI classifier is not included by default in the pyproject.toml file:

classifiers = [
"Framework :: Jupyter",
"Framework :: Jupyter :: JupyterLab",
"Framework :: Jupyter :: JupyterLab :: 4",
"Framework :: Jupyter :: JupyterLab :: Extensions",
"Framework :: Jupyter :: JupyterLab :: Extensions :: Prebuilt",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]

Proposed Solution

Adapt the Jinja template for the pyproject.toml file to include the following classifiers according to the extension type:

  • mimerenderer type -> Framework :: Jupyter :: JupyterLab :: Extensions :: Mime Renderers classifier
  • theme type -> Framework :: Jupyter :: JupyterLab :: Extensions :: Themes

Please let me know your opinion and if I can help/open a PR. Thanks!

@joaopalmeiro joaopalmeiro added the enhancement New feature or request label Sep 20, 2024
@krassowski
Copy link
Member

Good catch, PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants