Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region & profile model fields to BedrockEmbeddingsProvider #493

Closed
fbalicchia opened this issue Nov 29, 2023 · 2 comments · Fixed by #1136
Closed

Add region & profile model fields to BedrockEmbeddingsProvider #493

fbalicchia opened this issue Nov 29, 2023 · 2 comments · Fixed by #1136
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fbalicchia
Copy link

The goal of this feature Request is to enhance the configurability of the Bedrock embedded model by allowing users to set the region_name and profile parameters from chat config.

@fbalicchia fbalicchia added the enhancement New feature or request label Nov 29, 2023
Copy link

welcome bot commented Nov 29, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq
Copy link
Member

dlqqq commented Nov 27, 2024

Yes, this absolutely should be possible! Sorry this issue went undiscovered for so long.

I've assigned another contributor to this issue and added it to a milestone for tracking.

@dlqqq dlqqq modified the milestones: v3.0.0, Priority Nov 27, 2024
@dlqqq dlqqq changed the title Make region_name and profile configurable for bedrock embedded model too Add region & profile model fields to BedrockEmbeddingsProvider Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants